Moved discovery client implementation into his own library #2531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
force-pushed
the
discovery-client-lib
branch
from
094d429 to
9087d85
Compare
cmaglie
added
type: enhancement
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2531 +/- ##
==========================================
+ Coverage 68.95% 69.39% +0.43%
==========================================
Files 204 202 -2
Lines 20535 20110 -425
==========================================
- Hits 14160 13955 -205
+ Misses 5220 5035 -185
+ Partials 1155 1120 -35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cmaglie
force-pushed
the
discovery-client-lib
branch
from
9087d85 to
4dfb284
Compare
umbynos
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Moved the pluggable discovery client implementation in the
pluggable-discovery-protocol-handler/v2library.This change provides two benefits:
What is the current behavior?
No changes.
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Other information